Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with write, I think #15

Closed
HarelM opened this issue Aug 10, 2018 · 5 comments
Closed

Problem with write, I think #15

HarelM opened this issue Aug 10, 2018 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@HarelM
Copy link
Contributor

HarelM commented Aug 10, 2018

The following test fails, I think due to writing 1e-5 to the gpx file:

        [TestMethod]
        public void TestWriteRead()
        {
            var stream = new MemoryStream();
            var writer = new XmlTextWriter(stream, Encoding.UTF8);
            GpxWriter.Write(writer, 
                new GpxWriterSettings(), 
                new GpxMetadata(""), 
                new [] { new GpxWaypoint(new GpxLongitude(0.00001), new GpxLatitude(0.00001), null) }, 
                new GpxRoute[0], 
                new GpxTrack[0], 
                null);
            writer.Flush();
            stream.Seek(0, SeekOrigin.Begin);
            var reader = new XmlTextReader(stream);
            GpxReader.Read(reader, new GpxReaderSettings(), new NetTopologySuiteFeatureBuilderGpxVisitor(new GeometryFactory()));
        }
@airbreather airbreather self-assigned this Aug 11, 2018
@airbreather airbreather added the bug Something isn't working label Aug 11, 2018
@airbreather airbreather added this to the Alpha 0.2.0 milestone Aug 11, 2018
@airbreather
Copy link
Member

Thanks for the report, the fix will be in 0.2.0.

@HarelM
Copy link
Contributor Author

HarelM commented Aug 11, 2018

Thanks for the quick fix! Do you have an estimation when 0.2 will be released?

@airbreather
Copy link
Member

Do you have an estimation when 0.2 will be released?

Probably a couple of weeks or so. In the meantime, I have it set up so that each commit triggers an automated build that goes to my personal MyGet feed so you can try it out early: https://myget.org/feed/airbreather/package/nuget/NetTopologySuite.IO.GPX

@HarelM
Copy link
Contributor Author

HarelM commented Aug 11, 2018

It would be great if you could push this bug fix to a pre-release to NuGet, I would like to avoid adding NuGet sources to my project if possible...

@airbreather
Copy link
Member

Do you have an estimation when 0.2 will be released?

0.2.0 is on NuGet now.

It would be great if you could push this bug fix to a pre-release to NuGet, I would like to avoid adding NuGet sources to my project if possible...

Once this graduates past the 0.x series, then I think it'll make more sense to have small bug fixes go to NuGet with little delay. Until 1.0 (and even after) MyGet is always going to be the place to go for bleeding-edge versions (though I might tweak it to go onto the NTS feed instead of my personal one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants