You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As it turns out, 4STJ actually does write out null to signal an empty geometry, as shown in the longer repro below, which effectively means that the Json.NET version doesn't interoperate properly with the 4STJ version 😞:
RFC 7946 doesn't say one way or the other what to do with null here, and I can't find support elsewhere for what we were doing. It does, however, explicitly call out an empty array, and I do see other implementations using this, so we should prefer doing it this way.
Related to #65
RFC 7946 doesn't say one way or the other what to do with null here, and I can't find support elsewhere for what we were doing. It does, however, explicitly call out an empty array, and I do see other implementations using this, so we should prefer doing it this way.
Related to #65
In this situation, we will get
EndOfStreamException
.The issue is that this code doesn't consider the possibility that we might be on a
null
token:NetTopologySuite.IO.GeoJSON/src/NetTopologySuite.IO.GeoJSON/Converters/GeometryConverter.cs
Lines 354 to 357 in 3427249
As it turns out, 4STJ actually does write out
null
to signal an empty geometry, as shown in the longer repro below, which effectively means that the Json.NET version doesn't interoperate properly with the 4STJ version 😞:The text was updated successfully, but these errors were encountered: