Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GeoAPI dependency #49

Merged
merged 8 commits into from
Jul 3, 2019
Merged

Remove GeoAPI dependency #49

merged 8 commits into from
Jul 3, 2019

Conversation

FObermaier
Copy link
Member

  • Include necessary GeoAPI interfaces and value classes
  • Remove unnecessary GeoAPI interfaces
  • Make necessary code adjustments

* Include necessary GeoAPI interfaces and value classes
* Remove unnecessary GeoAPI interfaces
* Make necessary code adjustments
@FObermaier
Copy link
Member Author

@airbreather , I finally got around to removing GeoAPI from ProjNet4GeoAPI.
Could you please help on updating csproj files to versioning scheme as used in NTS now?
Feel free to use this branch.

The token string is copy-pasted from another project, and I don't want to generate one right now.
@airbreather
Copy link
Member

Could you please help on updating csproj files to versioning scheme as used in NTS now?

That's all taken care of now, with Travis-CI builds and everything.

@FObermaier
Copy link
Member Author

Thanks. A few more questions:

  • We don't need the *.nuspec file any more, do we.
  • the package is labeled ProjNet4GeoAPI. Now that we have removed the GeoAPI we should reflect that in the package name. We could either ask for ownership of https://www.nuget.org/packages/ProjNet/ or just label it Proj.Net.

@FObermaier FObermaier marked this pull request as ready for review July 2, 2019 12:09
@airbreather
Copy link
Member

We don't need the *.nuspec file any more, do we.

Correct; I removed it from the solution's associated files, but then I forgot to delete it entirely.

the package is labeled ProjNet4GeoAPI. Now that we have removed the GeoAPI we should reflect that in the package name. We could either ask for ownership of https://www.nuget.org/packages/ProjNet/ or just label it Proj.Net.

There's already a Proj.NET too...

Maybe NetTopologySuite.ProjNet?

@FObermaier
Copy link
Member Author

We now have ownership of ProjNET package. So we can move on or would you like to do some more reviewing @airbreather?

@airbreather
Copy link
Member

So we can move on or would you like to do some more reviewing @airbreather?

I think we can move on from this PR. I keep getting distracted by unrelated things I want to do, and all the style changes happening at the same time make it really hard to go through. I'm sure it's fine.

Windows users with core.autocrlf set to true will actually see an improvement.
@FObermaier FObermaier merged commit d521a2f into develop Jul 3, 2019
@FObermaier FObermaier deleted the wip/remove-geoapi branch July 3, 2019 11:21
@shmuelie
Copy link

Why was GeoAPI reference removed? Now I can't use this with NTS since they have different IProjections

@airbreather
Copy link
Member

@SamuelEnglard please open a new issue explaining the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants