Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibreSSL Support #91

Closed
hat001 opened this issue May 18, 2017 · 8 comments
Closed

LibreSSL Support #91

hat001 opened this issue May 18, 2017 · 8 comments

Comments

@hat001
Copy link
Contributor

hat001 commented May 18, 2017

cactus said at #87 (comment)

This seems to break running with LibreSSL.

I get this in the error logs

uam_load(uams_dhx.so): failed to load: /usr/local/libexec/netatalk-uams//uams_dhx.so: Undefined symbol "DH_set0_pqg"

From libressl you can see the version is higher:

opensslv.h:#define OPENSSL_VERSION_NUMBER	0x20000000L

I think you might want something like this for the version check instead?

#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)
@hat001
Copy link
Contributor Author

hat001 commented May 18, 2017

Did you test this patch?

By what environment did you test?
OpenBSD?

@hat001 hat001 mentioned this issue May 18, 2017
Closed
@dropwhile
Copy link

Currently testing the patch. So far, it compiles fine and starts up without the previous error.
System is FreeBSD.

@dropwhile
Copy link

dropwhile commented May 18, 2017 •
edited

Patch appears to be working. I have time machine backups running properly again (had to rollback to a zfs snapshot from a few days ago though).

@hat001
Copy link
Contributor Author

hat001 commented May 19, 2017

Please attach the patch file.

@dropwhile
Copy link

etc_uams_openssl__compat.h.diff.txt

@hat001
Copy link
Contributor Author

hat001 commented May 22, 2017

Just in case, I tested your patch on the following environments.

  • Fedora 25 (OpenSSL 1.0.2k)
  • Fedora 26 alpha (OpenSSL 1.1.0e)

It was no problem.
I'm going to create a patch for git.

uqs pushed a commit to freebsd/freebsd-ports that referenced this issue May 22, 2017
* Fix build with LibreSSL [1]
dc9af83 
* Use shebang fix to fix afpstats' use of Python

PR:		219366 [1]
Obtained from:	Netatalk/netatalk#91 [1]


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@441463 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this issue May 22, 2017
@xorrkaz
* Fix build with LibreSSL [1]
ff2d8f3 
* Use shebang fix to fix afpstats' use of Python

PR:		219366 [1]
Obtained from:	Netatalk/netatalk#91 [1]
@hat001
Copy link
Contributor Author

hat001 commented May 23, 2017

See Netatalk-devel ML
https://sourceforge.net/p/netatalk/mailman/message/35855444/

slowfranklin pushed a commit that referenced this issue May 24, 2017
@hat001 @slowfranklin
build with LibreSSL
399c6f6 
could not build with LibreSSL when supporting OpenSSL 1.1.

See also
b4a8025

Bug: <#91>

Signed-off-by: elij <elij@wundrd.net>
Reviewed-by: HAT <hat@fa2.so-net.ne.jp>
Reviewed-by: Ralph Boehme <slow@samba.org>
slowfranklin pushed a commit that referenced this issue May 24, 2017
@hat001 @slowfranklin
build with LibreSSL
8ace345 
could not build with LibreSSL when supporting OpenSSL 1.1.

See also
b4a8025

Bug: <#91>

Signed-off-by: elij <elij@wundrd.net>
Reviewed-by: HAT <hat@fa2.so-net.ne.jp>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 399c6f6)
@hat001
Copy link
Contributor Author

hat001 commented May 24, 2017

committed.
thanks!

@hat001 hat001 closed this as completed May 24, 2017
eyudin pushed a commit to keenetic/netatalk that referenced this issue Mar 2, 2021
@hat001 @vstarodubtsev
build with LibreSSL
365a885 
could not build with LibreSSL when supporting OpenSSL 1.1.

See also
b4a80257faee4bba0c2f54d4e78d7f3aa54f69c2

Bug: <Netatalk/netatalk#91>

Signed-off-by: elij <elij@wundrd.net>
Reviewed-by: HAT <hat@fa2.so-net.ne.jp>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 399c6f638286455988b0e9d00f2ae4324e6fee7b)
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this issue Jan 10, 2024
@xorrkaz
* Fix build with LibreSSL [1]
92ddbdf 
* Use shebang fix to fix afpstats' use of Python

PR:		219366 [1]
Obtained from:	Netatalk/netatalk#91 [1]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dropwhile @hat001