Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL 1.1 support #87

Closed
hat001 opened this issue Feb 25, 2017 · 4 comments
Closed

OpenSSL 1.1 support #87

hat001 opened this issue Feb 25, 2017 · 4 comments

Comments

@hat001
Copy link
Contributor

hat001 commented Feb 25, 2017

Netatalk currently does not build against OpenSSL 1.1.

https://wiki.openssl.org/index.php/1.1_API_Changes
@hat001
Copy link
Contributor Author

hat001 commented Feb 25, 2017 •
edited

OpenSSL 1.1.x compatibility #86

hat001 pushed a commit that referenced this issue Mar 13, 2017
@manover @hat001
dhx uams: OpenSSL 1.1 support
b4a8025 
Netatalk currently does not build against OpenSSL 1.1.0+,
producing a half a dozen error messages like this:

error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'

This is caused by OpenSSL having made certain structs opaque, which forces
the library users to employ special getters and setters when accessing
these structs.
This commit makes Netatalk support both old and new OpenSSL.

Bug: <#87>

Signed-off-by: Denis Bychkov <manover@gmail.com>
Reviewed-by: HAT <hat@fa2.so-net.ne.jp>
Reviewed-by: Ralph Boehme <slow@samba.org>
hat001 pushed a commit that referenced this issue Mar 13, 2017
@manover @hat001
dhx uams: OpenSSL 1.1 support
d3855e7 
Netatalk currently does not build against OpenSSL 1.1.0+,
producing a half a dozen error messages like this:

error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'

This is caused by OpenSSL having made certain structs opaque, which forces
the library users to employ special getters and setters when accessing
these structs.
This commit makes Netatalk support both old and new OpenSSL.

Bug: <#87>

Signed-off-by: Denis Bychkov <manover@gmail.com>
Reviewed-by: HAT <hat@fa2.so-net.ne.jp>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit b4a8025)
@hat001
Copy link
Contributor Author

hat001 commented Mar 15, 2017

Fixed in 3.1.11

@hat001 hat001 closed this as completed Mar 15, 2017
@dropwhile
Copy link

dropwhile commented May 18, 2017 •
edited

This seems to break running with LibreSSL.

I get this in the error logs

uam_load(uams_dhx.so): failed to load: /usr/local/libexec/netatalk-uams//uams_dhx.so: Undefined symbol "DH_set0_pqg"

From libressl you can see the version is higher:

opensslv.h:#define OPENSSL_VERSION_NUMBER	0x20000000L

I think you might want something like this for the version check instead?

#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)

@hat001 hat001 mentioned this issue May 18, 2017
Closed
@hat001
Copy link
Contributor Author

hat001 commented May 18, 2017

This ticket is closed already.
Go to new ticket #91 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dropwhile @hat001