[2.4] Update data types in codebase #1009
Conversation
dgsga
force-pushed
the
dgsga-v2uint
branch
6 times, most recently
from
c07c7ac
to
646bd3b
Compare
|
@rdmark, should we also consider changing: |
|
Sure, go for it. It seems Sonarcloud complains about this? |
dgsga
changed the title
include/wolfssl/wolfcrypt/settings.h
Outdated
| @@ -1797,25 +1797,25 @@ extern void uITRON4_free(void *p) ; | |||
| #define STRING_USER | |||
| #define XSTRCASECMP(s1,s2) strcasecmp((s1),(s2)) | |||
| #define XSTRCMP(s1,s2) strcmp((s1),(s2)) | |||
| #define XSTRLEN(pstr) ((CPU_SIZE_T)Str_Len((CPU_CHAR *)(pstr))) | |||
| #define XSTRLEN(pstr) ((CPU_SIZE_T)Str_Len((CPunsigned char *)(pstr))) | |||
There was a problem hiding this comment.
What does this data type mean?
Also, this settings.h header is one that you wrote, or is it copied verbatim from wolfssl?
There was a problem hiding this comment.
Well spotted as find and replace substituted U_CHAR as well as u_char! Fixed. Settings.h copied verbatim from WolfSSL
There was a problem hiding this comment.
Search-and-replace -- that explains it!
There are a handful more instances in the same settings.h that need to be reverted, I think. Please have a look.
|
Looks good to me. Only question is the wolfcrypt header. I'm not sure what those data types are, and if it was me I'd leave them as-is. :) |
|
No description provided.