Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2] Fix user visible typos and improve English grammar #399

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Aug 21, 2023

  • Removed two cases of explicit reference to the underlying implementation (Perl script)
  • Improve English grammar for a few sentences
  • Several typos reported by Debian's lintian
  • Capitalization fixes
  • Word choice improvements

@rdmark rdmark force-pushed the rdmark-issue-381-2 branch 2 times, most recently from f1dc27d to 8850159 Compare August 21, 2023 01:47
@rdmark
Copy link
Member Author

rdmark commented Aug 21, 2023

@NJRoadfan While correcting the papd man page it struck me that some of the info there may have to be updated following your changes to API, notable concerning PPD files. What do you think?

@NJRoadfan
Copy link
Contributor

Nothing needs to be changed. The CUPS interface always handled PPD files automatically, so you never needed the "pd" option unless you needed to override it for some reason. The whole reason why papd uses PPD files is that it was an easy source to provide information to driver queries.

With the revisions, IPP queries are used to pull that information from printers and stored in a generated PPD. This is to avoid extensively rewriting papd and to retain the ability to manually add printer queues the old fashioned way if someone isn't using CUPS.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rdmark rdmark merged commit b38b6fe into branch-netatalk-2-2 Aug 27, 2023
5 checks passed
@rdmark rdmark deleted the rdmark-issue-381-2 branch August 27, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants