Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2] Do not install at.h when glibc header is present #414

Merged
merged 1 commit into from Aug 27, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Aug 23, 2023

The at.h header conflicts with at.h distributed with glibc. Therefore, install the header only on systems where glibc isn't distributed by default. We still want to distribute it in the tarball, however.

As a side note, our at.h is probably relevant only for NetBSD presently, which is the one non-Linux OS where an appletalk kernel module is being kept alive.

@rdmark rdmark marked this pull request as draft August 23, 2023 19:02
@rdmark rdmark force-pushed the rdmark-issue-409 branch 2 times, most recently from d066023 to 94855e8 Compare August 23, 2023 19:03
@rdmark rdmark force-pushed the rdmark-issue-409 branch 4 times, most recently from b991e56 to 323806b Compare August 23, 2023 23:11
@rdmark rdmark marked this pull request as ready for review August 23, 2023 23:18
@rdmark
Copy link
Member Author

rdmark commented Aug 24, 2023

BTW, the current solution is a little awkward with the code duplication when assigning the same values twice to pkginclude_HEADERS. For some reason I couldn't make any changes to this variable after the first assignment and have it picked up by automake.

@rdmark rdmark changed the title [2.2] Do not install at.h on Linux [2.2] Do not install at.h when glibc header is present Aug 25, 2023
@rdmark rdmark merged commit 9b3d01d into branch-netatalk-2-2 Aug 27, 2023
3 checks passed
@rdmark rdmark deleted the rdmark-issue-409 branch August 27, 2023 20:27
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant