Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2] Correct install hook for static config files #421

Merged
merged 1 commit into from Aug 27, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Aug 26, 2023

The source path of static config files must be prefixed with $(srcdir) for out of tree builds to work.

It was already fixed for netatalk3 with this commit: a67d645

@rdmark rdmark changed the title Correct install hook for static config files, GitHub#408 [2.2] Correct install hook for static config files Aug 26, 2023
@VorpalBlade
Copy link

This seems to work. I also diffed two packages (one in tree the other out of tree) and there are no differing files.

There are however differences in the compiled binaries, which is strange. So, the builds are not fully reproducible, though that is a certainly a separate issue.

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rdmark rdmark merged commit f48869c into branch-netatalk-2-2 Aug 27, 2023
5 checks passed
@rdmark rdmark deleted the rdmark-issue-408 branch August 27, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants