Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2] autoconf: Fold a2boot and timelord under the appletalk conditional #424

Merged
merged 1 commit into from Aug 29, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Aug 28, 2023

  • Remove the distinct --enable-a2boot and --enable-timelord config options, and fold them under --enable-ddp.
  • Simplify appletalk conditionals in man makefiles

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rdmark rdmark changed the title autoconf: Fold a2boot and timelord under the appletalk conditional [2.2] autoconf: Fold a2boot and timelord under the appletalk conditional Aug 28, 2023
Copy link
Contributor

@dgsga dgsga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Daniel as a2boot and timelord have no relevance outside of the AppleTalk universe.

@rdmark
Copy link
Member Author

rdmark commented Aug 29, 2023

Thanks for reviewing.

The one drawback that I can think of with this change, is that whenever timelord or a2boot code won't compile on a niche platform you can't easily disable it at configure time anymore. But OTOH in the long run this is preferable since it incentivizes everyone to maintain the code.

@dgsga
Copy link
Contributor

dgsga commented Aug 29, 2023

Thanks for reviewing.

The one drawback that I can think of with this change, is that whenever timelord or a2boot code won't compile on a niche platform you can't easily disable it at configure time anymore. But OTOH in the long run this is preferable since it incentivizes everyone to maintain the code.

And fix compile failures as and when required. It would be good to have an idea of which host OS'es netatalk users are currently using. Maybe this is a way forward? https://github.blog/changelog/2022-04-12-discussions-polls/

@rdmark rdmark merged commit b956c09 into branch-netatalk-2-2 Aug 29, 2023
5 checks passed
@rdmark rdmark deleted the rdmark-issue-423 branch August 29, 2023 22:36
@rdmark
Copy link
Member Author

rdmark commented Aug 29, 2023

I like the idea of collecting user data. Ideally we should have (opt-in) user analytics that tells us what people are actually running it on rather what they say they're running it on. :)

One challenge is that the community is split between Github and the mailing lists, so I'd say engage with both.

@rdmark
Copy link
Member Author

rdmark commented Aug 29, 2023

Started a poll here #435

Please suggest any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants