Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Add long-forgotten patch to make papd safer. #527

Merged
merged 2 commits into from Oct 20, 2023
Merged

[2.3] Add long-forgotten patch to make papd safer. #527

merged 2 commits into from Oct 20, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Oct 14, 2023 •
edited

Quoting Chris K:

That was part of an attempt last year to make papd less dangerous. The code
constructs packets by allocating a char buffer and scribbling into that --
the patch replaces that nonsense with packed structs that dramatically reduces
the possibility of stack smashing.

@rdmark
Copy link
Member Author

rdmark commented Oct 14, 2023

@NJRoadfan Would you be able to test that I merged this correctly? It one of Chris K's patches that I cherry picked into the 2.x fork long time ago. But I don't have a vintage Mac to test that it works end to end right now.

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dgsga
Copy link
Contributor

dgsga commented Oct 14, 2023

@NJRoadfan Would you be able to test that I merged this correctly? It one of Chris K's patches that I cherry picked into the 2.x fork long time ago. But I don't have a vintage Mac to test that it works end to end right now.

Neither do I...

@rdmark rdmark changed the base branch from branch-netatalk-2-2 to branch-netatalk-2-3 October 15, 2023 06:16
@rdmark rdmark changed the title [2.2] Add long-forgotten patch to make papd safer. [2.3] Add long-forgotten patch to make papd safer. Oct 16, 2023
@NJRoadfan
Copy link

Appears to be working here.

@rdmark
Copy link
Member Author

rdmark commented Oct 20, 2023

Thanks for testing!

@rdmark rdmark merged commit 35ee222 into branch-netatalk-2-3 Oct 20, 2023
4 of 5 checks passed
@rdmark rdmark deleted the rdmark-papd-safer branch October 20, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NJRoadfan NJRoadfan NJRoadfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdmark @dgsga @NJRoadfan