Deprecate legacy cnid backends #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
rdmark
reviewed
Oct 15, 2023
Comment on lines
-2221
to
-2226
| <para>"Concurrent database", backend is based on Oracle Berkeley DB. | ||
| With this backend several <command>afpd</command> daemons access the | ||
| CNID database directly. Berkeley DB locking is used to synchronize | ||
| access, if more than one <command>afpd</command> process is active | ||
| for a volume. The drawback is, that the crash of a single | ||
| <command>afpd</command> process might corrupt the database.</para> |
There was a problem hiding this comment.
As a side note, when we remove this paragraph the following paragraph for dbd reads kind of awkwardly. We may want to borrow the first sentence?
rdmark
approved these changes
Oct 15, 2023
dgsga
added a commit
that referenced
this pull request
May 19, 2024
dgsga
added a commit
that referenced
this pull request
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes legacy CNID backends that complicate the user experience without providing significant functional gain