Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Remove cdb and tdb CNID backends #611

Merged
merged 1 commit into from Dec 27, 2023
Merged

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Dec 23, 2023

  • Removed cdb and tdb CNID backends
  • Removed in-memory tdb backend fallback
  • Updated documentation and code comments
  • Removed dead code

@rdmark rdmark requested a review from dgsga December 23, 2023 08:05
@rdmark rdmark force-pushed the rdmark-issue-535 branch 2 times, most recently from 10d1724 to 41e1063 Compare December 24, 2023 07:12
@rdmark
Copy link
Member Author

rdmark commented Dec 24, 2023

Unfortunately the error handling when the cnid_metad process is dead isn't good. You can connect to the shared volume, but the volume is shown as empty. Some more work is needed here...

Screenshot 2023-12-24 at 22 59 13

@rdmark rdmark marked this pull request as draft December 24, 2023 14:01
@rdmark rdmark force-pushed the rdmark-issue-535 branch 2 times, most recently from 013b5c6 to 39e1480 Compare December 25, 2023 00:14
@rdmark rdmark marked this pull request as ready for review December 25, 2023 00:14
@rdmark rdmark force-pushed the rdmark-issue-535 branch 3 times, most recently from 0c797df to 0a6fe53 Compare December 26, 2023 12:55
@rdmark rdmark marked this pull request as draft December 26, 2023 22:52
- Removed all references to cdb and tdb
- Removed in-memory tdb backend fallback
- Abort afpd when DB connection fails in get_id()
- Return error when DB connection fails in volume_openDB()
- Rewrote docs to clarify that dbd is the only option
- Removed dead code

Signed-off-by: Daniel Markstedt <daniel@mindani.net>
@rdmark rdmark marked this pull request as ready for review December 27, 2023 07:17
Copy link

sonarcloud bot commented Dec 27, 2023

@rdmark rdmark merged commit 60688d3 into branch-netatalk-2-3 Dec 27, 2023
4 checks passed
@rdmark rdmark deleted the rdmark-issue-535 branch December 27, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants