Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Switch from compile-time debug to run-time debug where applicable #618

Merged
merged 1 commit into from Dec 24, 2023
Merged

[2.3] Switch from compile-time debug to run-time debug where applicable #618

merged 1 commit into from Dec 24, 2023

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Dec 24, 2023 •
edited

  • Remove the --enable-debug --enable-debug1 configure options
  • refactor the afpd non-forking debug mode, and flip the afpd.conf option from -nodebug to -debug
  • Replace debug macros with debug9 level logs
  • in papd and atalkd, use the runtime debug mode instead of compile time macro

@rdmark rdmark force-pushed the rdmark-issue-536 branch 2 times, most recently from 28272d3 to 3e884e8 Compare December 24, 2023 07:10
@rdmark rdmark requested a review from dgsga December 24, 2023 07:13
@rdmark
Switch from compile-time debug to run-time debug Issue #536
c911c49 
 - Remove the --enable-debug and --enable-debug1 configure options
 - Replace DEBUG macros with debug9 level logs
 - Refactor the afpd non-forking debug mode, and flip the afpd.conf option from -nodebug to -debug
 - In papd and atalkd, use the runtime debug mode instead of compile time macro
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 24, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@rdmark rdmark merged commit 686be27 into branch-netatalk-2-3 Dec 24, 2023
3 of 4 checks passed
@rdmark rdmark deleted the rdmark-issue-536 branch December 24, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgsga dgsga dgsga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdmark @dgsga