Remove unneeded HAVE_TRACKER conditional #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have refactored the Spotlight macro so it meets all the following conditions:
This should help users identify which missing packages need to be installed for Spotlight support if required |
Refactor Spotlight macro Warn if any Spotlight support components are missing at configure time
dgsga
force-pushed
the
654-dgsga-spotlightfix
branch
from
690e506
to
fa20af7
Compare
rdmark
approved these changes
Jan 9, 2024
| #ifdef HAVE_TRACKER | ||
| printf( " tracker manager:\t%s\n", TRACKER_PREFIX "/bin/" TRACKER_MANAGING_COMMAND); | ||
|
|
||
| #ifdef WITH_SPOTLIGHT |
There was a problem hiding this comment.
Isn’t dbus strictly speaking used for other functionality too, even if you’re not building spotlight? E.g. afpstats
There was a problem hiding this comment.
Well spotted. I'll look into it as just moving bus-daemon path outside of the Spotlight conditional causes compilation failure.
dbus-session.conf is Spotlight only.
|
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 9, 2024
* Remove unneeded HAVE_TRACKER conditional * Refactor Spotlight macro * Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 9, 2024
* Remove unneeded HAVE_TRACKER conditional * Refactor Spotlight macro * Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 11, 2024
* Remove unneeded HAVE_TRACKER conditional * Refactor Spotlight macro * Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 13, 2024
* Remove unneeded HAVE_TRACKER conditional * Refactor Spotlight macro * Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 24, 2024
* Remove unneeded HAVE_TRACKER conditional * Refactor Spotlight macro * Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 24, 2024
* Remove unneeded HAVE_TRACKER conditional * Refactor Spotlight macro * Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
to dgsga/netatalk
that referenced
this pull request
Jan 24, 2024
• Remove unneeded HAVE_TRACKER conditional • Refactor Spotlight macro • Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
that referenced
this pull request
May 19, 2024
* Remove unneeded HAVE_TRACKER conditional • Refactor Spotlight macro • Warn if any Spotlight support components are missing at configure time
dgsga
added a commit
that referenced
this pull request
May 19, 2024
* Remove unneeded HAVE_TRACKER conditional • Refactor Spotlight macro • Warn if any Spotlight support components are missing at configure time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Spotlight macro
Warn if any Spotlight support components are missing at configure time