Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Fix missing rresvport function on systems using musl C library #920

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

dgsga
Copy link
Contributor

@dgsga dgsga commented Apr 29, 2024

This commit:

  • Fixes the missing rresvport function on linux systems using musl, credit @daimh

@dgsga dgsga self-assigned this Apr 29, 2024
@dgsga
Copy link
Contributor Author

dgsga commented Apr 29, 2024

@rdmark
The 2.4 branch now compiles fully on Alpine with both meson and autotools but we still have the issue of atalkd not loading correctly when built by meson. I also have no way of testing whether the new rresvport function works on Alpine. I found the code here, created for the very same reason:

https://github.com/daimh/sge/blob/master/source/libs/comm/glibc_rcmd.c

There is also a good overlap with the licensing :)

Any assistance with the atalkd issue is welcome, I have created the dgsga-alpine-atalkd branch to work on this issue

@dgsga dgsga changed the title [2.4] Fix compilation on systems using musl C library [2.4] Fix compilation on systems using musl C library WIP Apr 29, 2024
@dgsga dgsga marked this pull request as ready for review April 29, 2024 16:40
@dgsga dgsga requested a review from rdmark as a code owner April 29, 2024 16:40
@dgsga dgsga marked this pull request as draft April 29, 2024 16:40
@rdmark
Copy link
Member

rdmark commented Apr 30, 2024

@dgsga Great job! I will run some tests later today.

The MUSL detection logic is neat. Maybe in the long run when our local rresvport implementation has been "proven" we can use that across the board rather than the likely-to-be-deprecated glibc one.

@dgsga dgsga force-pushed the dgsga-v2-stdint branch 2 times, most recently from c316d4d to 375e1fb Compare April 30, 2024 09:22
@dgsga
Copy link
Contributor Author

dgsga commented Apr 30, 2024

@dgsga Great job! I will run some tests later today.

The MUSL detection logic is neat. Maybe in the long run when our local rresvport implementation has been "proven" we can use that across the board rather than the likely-to-be-deprecated glibc one.

@rdmark, I have separated out the different issues so they each have a separate PR (for easier tracking). So this PR now only contains the rresvport fix

@dgsga dgsga marked this pull request as ready for review April 30, 2024 09:30
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgsga dgsga changed the title [2.4] Fix compilation on systems using musl C library WIP [2.4] Fix compilation on systems using musl C library Apr 30, 2024
@dgsga dgsga changed the title [2.4] Fix compilation on systems using musl C library [2.4] Fix missing rresvport function on systems using musl C library Apr 30, 2024
@dgsga dgsga merged commit 43165fb into branch-netatalk-2-4 Apr 30, 2024
8 checks passed
@dgsga dgsga deleted the dgsga-v2-stdint branch April 30, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants