-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.4] Fix missing rresvport function on systems using musl C library #920
Conversation
@rdmark https://github.com/daimh/sge/blob/master/source/libs/comm/glibc_rcmd.c There is also a good overlap with the licensing :) Any assistance with the atalkd issue is welcome, I have created the dgsga-alpine-atalkd branch to work on this issue |
@dgsga Great job! I will run some tests later today. The MUSL detection logic is neat. Maybe in the long run when our local rresvport implementation has been "proven" we can use that across the board rather than the likely-to-be-deprecated glibc one. |
c316d4d
to
375e1fb
Compare
@rdmark, I have separated out the different issues so they each have a separate PR (for easier tracking). So this PR now only contains the rresvport fix |
|
This commit: