Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Update rc.openrc.tmpl: a2boot and timelord depend on atalkd #927

Merged

Conversation

NJRoadfan
Copy link

@NJRoadfan NJRoadfan commented Apr 30, 2024

We should only attempt to load timelord and a2boot if atalkd is running. Also register NBP entries on port 4 to be consistent with other init scripts.

To be consistent with the other init scripts, register NBP entries on port 4.
@NJRoadfan
Copy link
Author

The terminal output (at least on Alpine Linux) wouldn't look correct since the services stop in the reverse order.

Currently:

 * WARNING: you are stopping a boot service
 * Stopping afpd ...                                                                                              [ ok ]
 * Stopping papd ...                                                                                              [ ok ]
 * Stopping timelord ...                                                                                          [ ok ]
 * Stopping a2boot ...                                                                                            [ ok ]
 * Unregistering alpinetest:Workstation ...                                                                       [ ok ]
 * Unregistering alpinetest:netatalk ...                                                                          [ ok ]
 * Stopping atalkd ...                                                                                            [ ok ]
 * Stopping cnid_metad ...                                                                                        [ ok ]

There would be an awkward looking indent in the middle.

Copy link
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@rdmark rdmark merged commit b434be6 into Netatalk:branch-netatalk-2-4 May 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants