issue # 7 fix to be able to test system-users. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires OSGI config with service mapping for bundle 'biz.netcentric.aem.tools.accesscontrolvalidator.bundle' Service name in this config should be equal to system user id.
|
Closes #7 - @jochenkoschorke please review |
|
Thanks for your contribution and sorry for the late reply! The solution contained in this PR would require the addition of every service user in a service user mapping which is not very flexible and not suitable for multi tenant setups, each one having its own set of service users. A flexible solution should simply work by specifying a system user in a yaml configuration and the tool would do the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires OSGI config with service mapping for bundle
'biz.netcentric.aem.tools.accesscontrolvalidator.bundle'
Service name in this config should be equal to system user id.