Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sonarcloud.io execution to CI (incl. code coverage with jacoco) #493

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

kwin
Copy link
Member

@kwin kwin commented Oct 16, 2020

This closes #492

@kwin kwin requested a review from ghenzler October 16, 2020 07:23
Copy link
Member

@ghenzler ghenzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but where is the quality gate applied defined? Just at https://sonarcloud.io/project/activity?id=Netcentric_accesscontroltool "manually"? Can you also include the changes so the QG is green to start with?

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@kwin kwin merged commit a6b9d71 into develop Oct 16, 2020
@kwin kwin deleted the feature/492-sonarcloud.io branch October 16, 2020 14:45
@kwin kwin modified the milestone: 2.6.0 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sonarcloud.io integration
2 participants