#492 Sonar fixes #502
Merged
#492 Sonar fixes #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
requested changes
Oct 19, 2020
There was a problem hiding this comment.
I think the Sonarcloud issues are rather false positives and should just be disabled with annotations (https://github.com/SonarSource/sonar-java/blob/2e3b7d25cebac51d5040d30dc3048c2f575d6e92/its/plugin/projects/suppress-warnings/src/main/java/SuppressWarningsAtMethodLevelWithRule.java#L4)
accesscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/ui/AcToolUiService.java
Outdated
Show resolved
Hide resolved
accesscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/ui/AcToolUiService.java
Outdated
Show resolved
Hide resolved
|
Let us ignore javasecurity:S5145 as well. |
ghenzler
force-pushed
the
bugfix/492-sonar-fixes
branch
from
2de3b90
to
7e8ed54
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.