Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion column block #114

Closed
9 tasks done
Gonzalo-CG opened this issue Oct 13, 2023 · 10 comments
Closed
9 tasks done

Accordion column block #114

Gonzalo-CG opened this issue Oct 13, 2023 · 10 comments

Comments

@Gonzalo-CG
Copy link
Collaborator

Gonzalo-CG commented Oct 13, 2023

Description

A new Accordion Block (Accordion Column) will be developed to to achieve the design shown on Segment Landing - Figma, this block is used on the Trucks page Trucks - Figma.

This block has 2 variants for the desktop viewport:

  • Accordion Column Right (default):
Screenshot 2023-10-13 at 13 04 44
  • Accordion Column Left:
Screenshot 2023-10-13 at 13 04 59

Acceptance Criteria

  • The new Accordion block is available for authors to use on any page.
  • A block variant is available for authors to achieve the reversed (accordion on the left, image on the left) look.
  • Content editors can add hyperlink to any accordion section.
  • As a user, when I navigate through the different sections, the image changes.
  • As a user, when I change from one section to another the previous opened section closes and the new one opens (for all viewports).
  • The Design and style follows the figma specifications, for tablet we will be resembling the mobile solution (size to be specified).

Open Questions

  • The mobile design seems to imply that every accordion item has its own image (e.g. the image here is inside an accordion element), but on the desktop design, it seems that only one image is present on this component (the image is outside the accordion elements.
  • Name of the block. Name of block: Accordion Column Left (text on left)
    Variant: Accordion Column Right (text on right)
  • Name for the variation of the reversed look of the block.
@Gonzalo-CG Gonzalo-CG added Trucks and segments Question Further information is requested labels Oct 13, 2023
@BeckyMedlin
Copy link
Collaborator

@WendyKruger Please see Open Questions above.

@BeckyMedlin
Copy link
Collaborator

BeckyMedlin commented Oct 20, 2023

Per @WendyKruger, the image should change based on the accordion that's opened. Ex: When you click on Bulk Haul, the image needs to change to an image of a Bulk Haul.
Name of block: Accordion Column Left (text on left)
Variant: Accordion Column Right (text on right)

@DanielaPedrochevd DanielaPedrochevd self-assigned this Oct 23, 2023
@Gonzalo-CG Gonzalo-CG added HL estimate Design Question RE/Dev team has open questions regarding the designs. and removed Question Further information is requested labels Oct 24, 2023
@BeckyMedlin
Copy link
Collaborator

BeckyMedlin commented Oct 31, 2023

@Gonzalo-CG See Wendy's input above. Name of block = Accordion Column Left (text on left).
Please confirm if images can be added to existing accordion. If not, priority needs to be increased.

@BeckyMedlin BeckyMedlin removed the Design Question RE/Dev team has open questions regarding the designs. label Nov 14, 2023
@WendyKruger
Copy link
Collaborator

@BeckyMedlin why is this assigned to me?

@WendyKruger WendyKruger assigned cogniSyb and unassigned WendyKruger Nov 20, 2023
@BeckyMedlin
Copy link
Collaborator

@WendyKruger I believe I assigned it to you because the Design Question label was still present. I am not aware of any other needs for this one. @DanielaPedrochevd @cogniSyb Can you confirm that this one is ready for refinement? Is anything missing?

@DanielaPedrochevd DanielaPedrochevd changed the title Accordion with image Block Accordion column block Jan 4, 2024
@DanielaPedrochevd
Copy link
Collaborator

@WendyKruger can you please let us know what the tablet pixels are? Thank you!

@BeckyMedlin BeckyMedlin added the Design Question RE/Dev team has open questions regarding the designs. label Jan 4, 2024
@WendyKruger
Copy link
Collaborator

@DanielaPedrochevd checking with Matt G., will comment on the Figma file and tag both of you.

@DanielaPedrochevd
Copy link
Collaborator

DanielaPedrochevd commented Jan 29, 2024

After testing, we will wait until syb comes back to merge so he can review it code wise and branch test.

@cogniSyb cogniSyb removed their assignment Feb 13, 2024
@girishdigrajkar
Copy link
Collaborator

Observations are shared and awaiting fix/resolution/cross comments from Dev team

@girishdigrajkar
Copy link
Collaborator

Outstanding issues are fixed and able to get the correct results and hence, marking this ticket to done status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

7 participants