Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trucks lineup carousel (MVP) #13

Closed
cogniSyb opened this issue Aug 2, 2023 · 5 comments
Closed

Trucks lineup carousel (MVP) #13

cogniSyb opened this issue Aug 2, 2023 · 5 comments
Assignees
Labels
Homepage MVP Must have for october Redesign FE Redesign FE task Spillover
Milestone

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 2, 2023

MVP: We’ll copy the code of Netcentric/vg-volvotrucks-us-rd#16 and style it to fit into the Mack styling. Design will happen in the browser.

The navigation tabs will be positioned above the carousel images.

Design

To be done after #36

@cogniSyb cogniSyb added the Redesign FE Redesign FE task label Aug 2, 2023
@kesiah kesiah self-assigned this Aug 9, 2023
@ZoeBeykirch ZoeBeykirch changed the title Trucks lineup carousel Trucks lineup carousel (MVP) Aug 16, 2023
@shirin27 shirin27 added the MVP Must have for october label Aug 18, 2023
@DanielaPedrochevd
Copy link
Collaborator

@kesiah Can you please assign this ticket to @Andrei-Boiangiu if it is ready for testing? Thanks :)

@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done
with the mention of the two minor Bugs above and a slightly different rounded pixel size value of the Explore buttons

@WendyKruger WendyKruger added this to the MT Homepage milestone Dec 12, 2023
@WendyKruger
Copy link
Collaborator

@cogniSyb didn't we talk about Mack having the ability to use a different image for mobile in this block? I see the min-width code implemented on VTNA's version, but not on ours.

image
image

@cogniSyb
Copy link
Collaborator Author

@WendyKruger indeed, we talked about it in one of the design meetings. It was confirmed that the same image was expected on mobile/tablet. Changing this would mean implementing some adjustments.

@WendyKruger
Copy link
Collaborator

@WendyKruger indeed, we talked about it in one of the design meetings. It was confirmed that the same image was expected on mobile/tablet. Changing this would mean implementing some adjustments.

Let's definitely do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Homepage MVP Must have for october Redesign FE Redesign FE task Spillover
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

7 participants