Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Minor - Trucks Lineup Carousel - The title is not aligned with the navigation tabs #100

Closed
Andrei-Boiangiu opened this issue Sep 29, 2023 · 3 comments
Closed

Bug - Minor - Trucks Lineup Carousel - The title is not aligned with the navigation tabs #100

Andrei-Boiangiu opened this issue Sep 29, 2023 · 3 comments
Assignees
@Andrei-Boiangiu
Labels
Bugfix Something isn't working Homepage
Milestone
MT Homepage

Comments

@Andrei-Boiangiu
Copy link
Collaborator

On the Trucks Lineup Carousel, the title is not correctly aligned with the navigation tabs as according to the figma design

Steps to reproduce:

  1. Open https://13-trucks-carousel--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/laura/
  2. Open the figma design https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?node-id=2220%3A92927&mode=dev
  3. Notice that the position of the Title is not aligned with the navigation tabs as on the design

Expected result
Title should be aligned with the navigation tabs like on the figma design

Actual result
Title is not aligned with the navigation tabs like on the figma design

image
@Andrei-Boiangiu
Copy link
Collaborator Author

#13

@cogniSyb cogniSyb self-assigned this Oct 13, 2023
@ZoeBeykirch ZoeBeykirch added Bugfix Something isn't working Homepage labels Oct 16, 2023
@DanielaPedrochevd DanielaPedrochevd mentioned this issue Oct 18, 2023
Open
5 tasks
@DanielaPedrochevd
Copy link
Collaborator

confirmed as bug

@cogniSyb cogniSyb mentioned this issue Oct 31, 2023
Merged
@cogniSyb cogniSyb assigned Andrei-Boiangiu and unassigned cogniSyb Nov 1, 2023
@Andrei-Boiangiu
Copy link
Collaborator Author

confirmed as fixed
as tested on https://100-lineup-tabs--vg-macktrucks-com-rd--netcentric.hlx.page/homepage

image

cogniSyb added a commit that referenced this issue Nov 3, 2023
@cogniSyb
Trucks Lineup Carousel - The title is not aligned with the navigation…
32911ae 
… tabs #100 (#156)
@WendyKruger WendyKruger added this to the MT Homepage milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrei-Boiangiu Andrei-Boiangiu

Labels
Bugfix Something isn't working Homepage
Projects
None yet
Milestone
MT Homepage
Development

When branches are created from issues, their pull requests are automatically linked.

100-lineup-tab-alignment Netcentric/vg-macktrucks-com-rd
100-lineup-tabs Netcentric/vg-macktrucks-com-rd
5 participants
@ZoeBeykirch @Andrei-Boiangiu @cogniSyb @WendyKruger @DanielaPedrochevd