Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truck features #43

Closed
4 tasks done
cogniSyb opened this issue Aug 16, 2023 · 2 comments · Fixed by #155
Closed
4 tasks done

Truck features #43

cogniSyb opened this issue Aug 16, 2023 · 2 comments · Fixed by #155
Assignees
@Andrei-Boiangiu @WendyKruger
Labels
PDP Spillover
Milestone
MT PDP

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 16, 2023 •
edited by DanielaPedrochevd
Loading

Highlighting truck features. This component utilises scroll snap to jump from one subject to the other.

Requirements

  • On desktop, image is shown on left or right
  • On mobile, the image is always shown between header and text
  • Image can change on every state
  • Scroll/active element indicator (red line on side of text)
  • Header nor text is clickable. The text can contain links
  • The height of the block is as tall as the viewport but minus the in-page nav.

UX points to clarify

Image
@shirin27 shirin27 added the MVP Must have for october label Aug 23, 2023
@Lakshmishri Lakshmishri mentioned this issue Aug 30, 2023
Closed
@DanielaPedrochevd DanielaPedrochevd removed the MVP Must have for october label Oct 23, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 27, 2023
@tdziezykDS
#43 Init truck features
17528fa
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 27, 2023
@tdziezykDS
#43 Style update
c5246a8
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 27, 2023
@tdziezykDS
#43 Add support for touch events
95a9169
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 27, 2023
@tdziezykDS
#43 Add mobile styles
9d710e1
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 30, 2023
@tdziezykDS
#43 Update desktop styles
b2f4eee
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 30, 2023
@tdziezykDS
#43 Update css for desktop
e8deb86
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 30, 2023
@tdziezykDS
#43 Update link colors
e1da223
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 30, 2023
@tdziezykDS
#43 Add image-left variant
4e8838a
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 30, 2023
@tdziezykDS
#43 Update css
f9bf250
Merged
TomaszDziezykNetcentric pushed a commit that referenced this issue Oct 30, 2023
@tdziezykDS
#43 Update slide change time
c69f361
@DanielaPedrochevd DanielaPedrochevd added this to the MT PDP milestone Nov 3, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 6, 2023
@tdziezykDS
#43 Change the wheel event to scroll
8ceaedf
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 6, 2023
@tdziezykDS
#43 Update the content height
19fb474
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 6, 2023
@tdziezykDS
#43 Fix scrolling event
7f0d786
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 7, 2023
@tdziezykDS
#43 Update default height of the inpage nav
ae7a3ed
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 9, 2023
@tdziezykDS
#43 Show modal on Open gallery button click
25bc376
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 10, 2023
@tdziezykDS
#43 Fixes after CR
6079f08
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 13, 2023
@tdziezykDS
#43 Refactor
389d8ef
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 14, 2023
@tdziezykDS
#43 Refactor the scroll behavior
d18774e
@cogniSyb cogniSyb added the Design Question RE/Dev team has open questions regarding the designs. label Nov 15, 2023
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 15, 2023
@tdziezykDS
#43 Refactor
8b77a05
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 15, 2023
@tdziezykDS
#43 Update scrolling padding
e21ff5d
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 16, 2023
@tdziezykDS
#43 Update image sizes for 1440
5da735d
@Andrei-Boiangiu
Copy link
Collaborator

confirmed as done
as tested on https://43-truck-features--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/tdziezyk/v2/truck-features

@BeckyMedlin
Copy link
Collaborator

@WendyKruger @cogniSyb requests 1600*1480px pictures for this ticket.

TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 17, 2023
@tdziezykDS
#43 Update mobile align
af23976
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 17, 2023
@tdziezykDS
#43 Udpate content height calculation
af7f996
TomaszDziezykNetcentric pushed a commit that referenced this issue Nov 17, 2023
@tdziezykDS
#43 Remove debounce
45cc155
cogniSyb pushed a commit that referenced this issue Nov 17, 2023
@TomaszDziezykNetcentric
Truck features #43 (#155)
97cd568
@WendyKruger WendyKruger mentioned this issue Dec 11, 2023
Closed
@WendyKruger WendyKruger removed the Design Question RE/Dev team has open questions regarding the designs. label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrei-Boiangiu Andrei-Boiangiu

@WendyKruger WendyKruger

Labels
PDP Spillover
Projects
None yet
Milestone
MT PDP
Development

Successfully merging a pull request may close this issue.

Truck features #43 Netcentric/vg-macktrucks-com-rd
8 participants
@Lakshmishri @TomaszDziezykNetcentric @Andrei-Boiangiu @cogniSyb @WendyKruger @shirin27 @BeckyMedlin @DanielaPedrochevd