Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs #44

Closed
1 of 2 tasks
cogniSyb opened this issue Aug 16, 2023 · 6 comments
Closed
1 of 2 tasks

Breadcrumbs #44

cogniSyb opened this issue Aug 16, 2023 · 6 comments
Assignees
Labels
Enhancement New feature or request General Redesign FE Redesign FE task Solutions

Comments

@cogniSyb
Copy link
Collaborator

cogniSyb commented Aug 16, 2023

Agile Requirement
As a business owner, I want to display the breadcrumb in a clear and appealing way to the user.

Business need
Redesign of breadcrumbs needs to be implemented. This block occurs pages below Trucks and Solutions.

A new block V2 Breadcrumbs need to be created, as the current block is used on some existing magazine pages that don’t include redesign styles. Adjusting the current block has no value as the breadcrumbs don’t appear in the redesigned magazine.

Acceptance criteria

  • A content editor should be able to place the block on any page
  • The content will be pulled from the URL, replacing dashes with spaces, and will be capitalised
    • Each item will link to a part of the URL
  • The HTML needs to be accessible
    • The slash is not part of content
  • The following states of links need to be created:
    • Regular
    • Hover
    • Focus (focus-visible only, red line as per other focus states)
    • Active
  • Tablet will follow desktop as much as possible, making use of available space (see next point)
  • When there’s too much content available for the viewport, some content will be hidden
    1. Homepage
    2. Current page
    3. Any page above the current’s page parent

Solution for progressively hiding content: https://codepen.io/KenanYusuf/pen/JKEjOR?editors=0100
We’re not reusing the example from Adobe, as it will mean an adjustment to the header.

Questions

Screenshot 2024-01-29 at 11 50 44

NOTE: On roadchoice we introduced horizontal scrolling: https://www.roadchoice.com/blog/belts-matter-a-guide-to-ensuring-reliability-in-your-vehicle
Screenshot 2024-01-29 at 12 05 36

@cogniSyb cogniSyb added Redesign FE Redesign FE task General Question Further information is requested labels Aug 16, 2023
@ZoeBeykirch
Copy link
Collaborator

@manuel-vara Is this part of the navigation?

@shirin27 shirin27 added MVP Must have for october HL estimate labels Sep 4, 2023
@shirin27
Copy link
Collaborator

shirin27 commented Sep 4, 2023

@cogniSyb @ZoeBeykirch since this is not part of te PDP or homepage, this should not be in scope for MVP, no?

@ZoeBeykirch
Copy link
Collaborator

No doesn't need to be part of MVP

@shirin27 shirin27 removed the MVP Must have for october label Sep 6, 2023
@Gonzalo-CG Gonzalo-CG added Design Question RE/Dev team has open questions regarding the designs. and removed Question Further information is requested labels Oct 25, 2023
@DanielaPedrochevd DanielaPedrochevd modified the milestones: MT Homepage, MT PDP Oct 31, 2023
@BeckyMedlin BeckyMedlin removed this from the MT PDP milestone Nov 8, 2023
@DanielaPedrochevd DanielaPedrochevd added this to the MT Enhancements milestone Nov 9, 2023
@DanielaPedrochevd DanielaPedrochevd added the Enhancement New feature or request label Nov 9, 2023
@WendyKruger
Copy link
Collaborator

Redesign of breadcrumbs needs to be implemented.

Questions

@cogniSyb Please follow the Code Design Kit

@WendyKruger WendyKruger removed the Design Question RE/Dev team has open questions regarding the designs. label Nov 20, 2023
@WendyKruger WendyKruger assigned cogniSyb and unassigned WendyKruger Nov 20, 2023
@WendyKruger
Copy link
Collaborator

@BeckyMedlin @DanielaPedrochevd I would like to bump this up as a #1 priority to be handled in the next sprint.

@girishdigrajkar
Copy link
Collaborator

Validated and able to get the correct results and hence, marking the ticket to done status:

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request General Redesign FE Redesign FE task Solutions
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

9 participants