Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Major - Mobile view - Testimonial - The text is show first on Mobile view for a Testimonial with video and media left #53

Closed
Andrei-Boiangiu opened this issue Aug 22, 2023 · 3 comments · Fixed by #67
Assignees

Comments

@Andrei-Boiangiu
Copy link
Collaborator

Andrei-Boiangiu commented Aug 22, 2023

Testimonial block with media on the left and with video will have the text displayed first on Mobile view

Steps to reproduce:

  1. Go to https://11-testimonial-block--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/tdziezyk/v2/testimonial
  2. Notice the testimonials with the image / with video on the left
  3. Switch to Mobile view the same page
  4. Notice that the Testimonial blocks with media on the left have the text displayed first like the ones with media on right

Expected result
Media on the left should have the image displayed first on Mobile view

  • see figma in original ticket

Actual result
Testimonial with media on the left and with video will also have the text displayed first in Mobile view

image
@Andrei-Boiangiu
Copy link
Collaborator Author

#11

@TomaszDziezykNetcentric
Copy link
Collaborator

Hi @Andrei-Boiangiu
The business decided to always display the text first and then the image on mobile devices, regardless of the order of display on the desktop. Please check the second point in the issue #11 description

@Andrei-Boiangiu
Copy link
Collaborator Author

as it was decided we hant to have the image/media always on top on Mobile view for testimonials regardless where it is displayed in the Dekstop view

confirmed as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants