Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Critical - Footer - Font sizes are incorrect on the Footer links and items #78

Closed
Andrei-Boiangiu opened this issue Sep 19, 2023 · 1 comment
Closed

Bug - Critical - Footer - Font sizes are incorrect on the Footer links and items #78

Andrei-Boiangiu opened this issue Sep 19, 2023 · 1 comment
Assignees
@cogniSyb
Milestone
MT Homepage

Comments

@Andrei-Boiangiu
Copy link
Collaborator

Font sizes are incorrect in the Footer of MackTrucks

Steps to reproduce:

  1. Go to https://main--vg-macktrucks-com-rd--netcentric.hlx.page/ and scroll down to the Footer
  2. Notice the incorrect font sizes on the items

Expected result
Footer items should be correctly displayed with the right font sizes

image

Actual result
Footer items are have the incorrect font size

image
@cogniSyb cogniSyb self-assigned this Sep 19, 2023
@cogniSyb cogniSyb mentioned this issue Sep 19, 2023
Merged
cogniSyb added a commit that referenced this issue Sep 19, 2023
@cogniSyb
fix regression with typography #78, fix footer alignment #77
daa2a1e
cogniSyb added a commit that referenced this issue Sep 20, 2023
@cogniSyb
fix regression with typography #78, fix footer alignment #77
4421d36
cogniSyb added a commit that referenced this issue Sep 20, 2023
@cogniSyb
#78 fix font size rounding issues
2e862e8
cogniSyb added a commit that referenced this issue Sep 20, 2023
@cogniSyb
#78 fix specificity issues in selectors
11ea98c
Lakshmishri added a commit that referenced this issue Sep 20, 2023
@Lakshmishri
Merge pull request #79 from Netcentric/78-bug-footer-and-font-sizes
b45e851 
fix regression with typography #78, fix footer alignment #77
@Andrei-Boiangiu
Copy link
Collaborator Author

this is fixed on https://main--vg-macktrucks-com-rd--netcentric.hlx.page/homepage
but still present on the URL without the homepage: https://main--vg-macktrucks-com-rd--netcentric.hlx.page/
will be closed as fixed. please let me know if otherwise for the basic URL

@DanielaPedrochevd DanielaPedrochevd added this to the MT Homepage milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cogniSyb cogniSyb

Labels
None yet
Projects
None yet
Milestone
MT Homepage
Development

When branches are created from issues, their pull requests are automatically linked.

78-bug-critical-footer-font-sizes-are-incorrect-on-the-footer-links-and-items Netcentric/vg-macktrucks-com-rd
3 participants
@Andrei-Boiangiu @cogniSyb @DanielaPedrochevd