Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media with content block #140 #210

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Media with content block #140 #210

merged 5 commits into from
Feb 13, 2024

Conversation

SantiagoHomps-NC
Copy link

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 30, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 30, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/shomps/redesign/media-with-content PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@SantiagoHomps-NC SantiagoHomps-NC marked this pull request as ready for review January 30, 2024 16:45
@cogniSyb cogniSyb changed the title Media with content block Media with content block #140 Feb 7, 2024
cogniSyb
cogniSyb requested changes Feb 8, 2024
View reviewed changes
blocks/v2-media-with-content/v2-media-with-content.css Outdated Show resolved Hide resolved
blocks/v2-media-with-content/v2-media-with-content.css Outdated Show resolved Hide resolved
blocks/v2-media-with-content/v2-media-with-content.css Outdated Show resolved Hide resolved
blocks/v2-media-with-content/v2-media-with-content.css Outdated Show resolved Hide resolved
blocks/v2-media-with-content/v2-media-with-content.js Outdated Show resolved Hide resolved
blocks/v2-media-with-content/v2-media-with-content.js Outdated Show resolved Hide resolved
@cogniSyb cogniSyb added the FR Functional requirement label Feb 8, 2024
@SantiagoHomps-NC SantiagoHomps-NC merged commit c543ce0 into develop Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-lledo-netcentric jonatan-lledo-netcentric jonatan-lledo-netcentric approved these changes

@cogniSyb cogniSyb cogniSyb approved these changes

@manuel-vara manuel-vara Awaiting requested review from manuel-vara

Assignees

@cogniSyb cogniSyb

Labels
FR Functional requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SantiagoHomps-NC @jonatan-lledo-netcentric @cogniSyb @santi-homps