Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all the icons for Mack trucks in the codebase #49 #89

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Add all the icons for Mack trucks in the codebase #49 #89

merged 4 commits into from
Oct 17, 2023

Conversation

Lakshmishri
Copy link
Collaborator

@Lakshmishri Lakshmishri commented Sep 22, 2023 •
edited by cogniSyb
Loading

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 22, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 22, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/columns PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kesiah
Copy link
Collaborator

kesiah commented Sep 26, 2023

I see some inconsistencies btw the icons, some strokes are bolder than others. Maybe we can ask UX team to provide a common stroke-width, that we could apply to all mack icons. Wdyt @Lakshmishri @cogniSyb ?

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 27, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 27, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/columns PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

cogniSyb
cogniSyb previously requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@cogniSyb cogniSyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you group some <path> tags in <g> and move te repeating stroke attributes in that tag?

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 29, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/columns PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Lakshmishri
Copy link
Collaborator Author

Could you group some <path> tags in <g> and move te repeating stroke attributes in that tag?

I have updated all svg as per your suggestions, please check

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 17, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/columns PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb changed the title add icons Add all the icons for Mack trucks in the codebase (#49) Oct 17, 2023
@cogniSyb cogniSyb changed the title Add all the icons for Mack trucks in the codebase (#49) Add all the brand icons for Mack trucks in the codebase (#49) Oct 17, 2023
@cogniSyb cogniSyb dismissed their stale review October 17, 2023 13:50

fixed changes myself

@cogniSyb cogniSyb merged commit bbeb1c7 into develop Oct 17, 2023
2 checks passed
@cogniSyb cogniSyb added FR Functional requirement NFR Non-functional requirement and removed FR Functional requirement labels Nov 7, 2023
@cogniSyb cogniSyb changed the title Add all the brand icons for Mack trucks in the codebase (#49) Add all the icons for Mack trucks in the codebase #49 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesiah kesiah kesiah approved these changes

@TomaszDziezykNetcentric TomaszDziezykNetcentric TomaszDziezykNetcentric approved these changes

@markovukiceviccn markovukiceviccn Awaiting requested review from markovukiceviccn

@cogniSyb cogniSyb Awaiting requested review from cogniSyb

Assignees
No one assigned
Labels
NFR Non-functional requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lakshmishri @kesiah @TomaszDziezykNetcentric @cogniSyb