Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggr: ensure publisher future completes #400

Merged
merged 1 commit into from
Mar 7, 2023
Merged

aggr: ensure publisher future completes #400

merged 1 commit into from
Mar 7, 2023

Conversation

brharrington
Copy link
Contributor

Make the publisher queue size configurable. Adjust future to ensure it will always be completed even if the stream gets restarted. Now it will be completed when returned and treated as successful if it was enqueued. This avoids problems with the upstream hanging if the stream is restarted and some of the returned futures are never completed.

Make the publisher queue size configurable. Adjust future
to ensure it will always be completed even if the stream
gets restarted. Now it will be completed when returned and
treated as successful if it was enqueued. This avoids
problems with the upstream hanging if the stream is restarted
and some of the returned futures are never completed.
@brharrington brharrington merged commit 0ddc00d into Netflix-Skunkworks:main Mar 7, 2023
@brharrington brharrington deleted the aggr-queue branch March 7, 2023 02:56
manolama pushed a commit to manolama/iep-apps that referenced this pull request Oct 25, 2023
Make the publisher queue size configurable. Adjust future
to ensure it will always be completed even if the stream
gets restarted. Now it will be completed when returned and
treated as successful if it was enqueued. This avoids
problems with the upstream hanging if the stream is restarted
and some of the returned futures are never completed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant