Add cpu utilization as a parameter with which desires can be obtained #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsrivatsa
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
from
2c09f54
to
352a776
Compare
ramsrivatsa
changed the title
jolynch
requested changes
Oct 13, 2023
ramsrivatsa
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
from
7412df2
to
82dd4c5
Compare
|
i noticed a lot of whitespace change. @jolynch what is there a formatter that you used? |
|
I don't think the model should be aware what the current instance is. I would like to see the current instance to be used as signal to the planner that one of the least_regret plans must be of that instance. that way we could:
this also introduces more challenges to compositions of models since a kv cluster would likely have a different current instance than the composed cassandra. I'm thinking we should depreciate composition and have the client invoke the planner for each model separately. |
jolynch
requested changes
Oct 19, 2023
ramsrivatsa
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
4 times, most recently
from
4cbb8a5
to
ffb2e55
Compare
abersnaze
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
from
ffb2e55
to
a76552e
Compare
ramsrivatsa
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
from
a76552e
to
67413e8
Compare
abersnaze
approved these changes
Oct 25, 2023
…pes (+5 squashed commits) Squashed commits: [aa15bd9] joey changes on new types [592def6] consolidate current instance type (str), count (interval), cpu% (interval) into a new model object [82dd4c5] required cluster type parameter is now per zone [0ce2064] Moved instance type definition inside interface (joey comments addressed) [352a776] Add cpu utilization as a parameter in extra model arguments; If you have cpu usage already use it directly
ramsrivatsa
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
2 times, most recently
from
d953a3b
to
fac3418
Compare
ramsrivatsa
force-pushed
the
ramsrivatsak/cpu-utilization-cass
branch
from
fac3418
to
de475e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CPU utilization directly within extra model arguments. If we have utilization numbers, we can directly leverage them to obtain desired instance types. If we don't, then use the default reads and writes to compute CPU util which in turn can be used to obtain desired instance types.
Also added pytest in the setup so that it can integrate seamlessly with pycharm.