This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Fix pseudo VMs lease cloning #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spodila
commented
May 9, 2017
spodila
commented
- Fix cloning of leases for pseudo VMs, update totals before use
- unit test to replicate problem with cloned leases before this fix when using active VMs list
tbak
reviewed
May 9, 2017
| if (currTotalLease == null) | ||
| logger.debug("Updated total lease is null"); | ||
| else { | ||
| logger.debug("Updated total lease has cpu= " + currTotalLease.cpuCores() + ", mem=" + currTotalLease.memoryMB() + |
There was a problem hiding this comment.
For better performance use '{}' template parameter.
| avm.updateCurrTotalLease(); | ||
| final VirtualMachineLease currTotalLease = avm.getCurrTotalLease(); | ||
| if (currTotalLease == null) |
There was a problem hiding this comment.
Is it ok for this to happen? If not lets change log level to warn, and add more information (AVM hostname?)
There was a problem hiding this comment.
Yes, this can happen for regular VMs (not pseudo VMs).
| @@ -191,13 +200,49 @@ public boolean isShutdown() { | |||
| } | |||
| } | |||
| } | |||
| else if(pHostsAdded > 0) { | |||
| logger.debug("No pseudo assignments made, looking for failures"); | |||
There was a problem hiding this comment.
This is all about logging at debug level, so lets wrap it with if(logger.isDebugEnabled()).
|
Changes made in next PR except as noted above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.