threadPoolProperties ignored in GenericSetterBuilder#buildObservableCommandSetter

[ghostganz]

Using HystrixCommand annotation on a method returning Observable, the "threadPoolProperties" are ignored.

https://github.com/Netflix/Hystrix/blob/master/hystrix-contrib/hystrix-javanica/src/main/java/com/netflix/hystrix/contrib/javanica/command/GenericSetterBuilder.java

It's because the build() method (for non-Observables) copies those settings, but they are ignored in the buildObservableCommandSetter(). There's a TODO there hinting at the problem.

Most users won't notice this, since the isolation strategy doesn't default to THREAD for observables.

[ghostganz]

More of the same problem: HystrixObservableCommand.Setter has protected fields threadPoolKey and threadPoolPropertiesDefaults, but there's no way to change them.

[ramnight]

Is that a bug?
Or is there any other reason?
I want to use the Observable in THREAD mode, but I can't change the thread pool config。

[mattrjacobs]

I can't think of any reason you would use a thread pool with HystrixObservableCommand. There's an outstanding issue to deprecate and remove this API (#1200), but that hasn't been done yet.

[ramnight]

I found solution in #805 (comment),
thanks a lot.

[ghostganz]

We have, for historical reasons, things that use Observable although they aren't completely asynchronous, so we need threads to have those things running well.

In an ideal world that wouldn't be needed, but ...