New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new dashboard do not display the command statistics detail #827
Comments
Any update? |
hi, @mattrjacobs |
I'm on vacation at the moment. @benjchristensen / @KoltonAndrus - can one Sent from my iPhone On Jul 7, 2015, at 5:39 AM, dennis zhuang notifications@github.com wrote: hi, @mattrjacobs https://github.com/mattrjacobs — |
Since it's been working for years, it could be some recent change, something about your server, something about your browser, or something else completely. I do not have time to look into this right now as I'm heads down on other higher priority items. I suggest trying older versions to see if it is legitimately the newer versions that are broken. Also, all the code is of course available on Github, so if you can debug your issue and find it's a problem in the code, please provide the details or submit a pull request with a fix. If you're unable to debug it or find an older version that works, we'll keep the issue open until someone has time. |
All right. 2015-07-09 0:06 GMT+08:00 Ben Christensen notifications@github.com:
庄晓丹 |
Fwiw we're seeing the same thing. Dashboard up to and including v1.4.6 works fine with all our streams. Dashboard v1.4.7 (and newer) displays as shown above for all our streams. So some change in v1.4.7 must have broken it. Using the latest Hystrix with Dashboard v1.4.6 works fine for us, so that's what we're doing. |
That is very helpful information. If one of you don't figure out what's wrong before we do, one of us will get to this. |
I don't rollback the dashboard version. I am sorry, i forgot to save the log in browser console, there were some The error happens in tmpl.js 40 line:
Hope above information is helpful for you to get to this , or someone see 2015-07-09 22:24 GMT+08:00 Ben Christensen notifications@github.com:
庄晓丹 |
I found the errors in browser console:
|
(Clearing the browser cache didn't make any difference for me.) As noted above, the error appearing repeatedly in the console is:
The counter rollingCountBadRequests was added recently in commit 892f6a7, and is now required by the template. Our streams pre-date this change and do not contain rollingCountBadRequests. Seems to me it would be helpful to keep the dashboard backwards compatible with older streams. I created a pull request with a simple fix: #830 |
Just merged PR #830. As I try to prioritize Hystrix work, I'm curious how much effort should be spent on the goal of making the Hystrix dashboard work with any officially-released version of a metrics schema. In general, we upgrade metrics-streams/core Hystrix first before upgrading surrounding visualizations (like the dashboard) at Netflix. @killme2008 / @jeremybull What specifically caused you to upgrade the dashboard but not the metrics streams? Have you had problems with upgrading hystrix-core? Conversely, is there an important feature in the dashboard that you wanted that you didn't want to incur the cost of a hystrix-core upgrade for? |
@mattrjacobs |
@mattrjacobs: We are gradually adding circuit breakers to all our applications. So our use case is:
My primary difficulty (perhaps due to my ignorance) was determining stream versions without the app source code. I used trial and error, pulling older and older tags of the dashboard from git until I was able to view all streams. |
OK, thanks for the context. This hadn't bitten us yet, so I wanted to make sure I understand your use cases. I think this should be fairly straightforward to implement - I'll ping this thread when I've got a solution |
I took a look at the code, and I didn't see a great way to go beyond the PR submitted by @jeremybull. There was a data validation step that I neglected to add the bad requests metrics to - that would have made this issue somewhat easier to spot. |
@mattrjacobs |
@killme2008 Added a new issue to track: #840 |
Fix by @jeremybull released in 1.4.13: https://github.com/Netflix/Hystrix/releases/tag/v1.4.13. If this works as expected, please close this issue. |
As said in wiki https://github.com/Netflix/Hystrix/wiki/Dashboard, we can see many statistics detail informations for every command, such as request rate, request latency etc.
But now we are using the latest hystrix dashboard ,there are no such detail informations except the graph for every command as below:
Why it happens? How can we see the command statistics detail? Thanks a lot.
The text was updated successfully, but these errors were encountered: