Make methods of Hystrix class thread-safe #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NetflixOSS » Hystrix » Hystrix-pull-requests #297 SUCCESS |
|
I'm going to merge this as-is, and open up a new issue for how |
mattrjacobs
added a commit
that referenced
this pull request
Jan 8, 2016
…ing-command-list-thread-safe Make methods of Hystrix class thread-safe
mattrjacobs
deleted the
make-hystrix-current-executing-command-list-thread-safe
branch
|
I reviewed the code and it looks good! Great that you could reproduce it in the unit test. As soon as the next Hystrix version is released I will upgrade it in our application and check the logging to see if the problem is gone. For now I will close the issue. Thanks for fixing it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1012. The
testMultipleSemaphoreObservableCommandsInFlightunit test failed consistently when using aLinkedListinstead of theConcurrentStack.Would you mind taking a look, @mzeijen? Thanks again for bringing this up. I'll add the deprecation as the next commit if you think this looks like the right approach.