Removed methods and variables with unused annotation #1154
Conversation
|
NetflixOSS » Hystrix » Hystrix-pull-requests #419 SUCCESS |
|
Hi @mattrjacobs when you have time could you check this, please? |
| @@ -134,19 +134,6 @@ public boolean isRunning() { | |||
| /** | |||
| * Used to protect against leaking ExecutorServices and threads if this class is abandoned for GC without shutting down. | |||
| */ | |||
| @SuppressWarnings("unused") | |||
There was a problem hiding this comment.
This one does get called, just not within the Hystrix library. See http://stackoverflow.com/questions/6872857/how-does-a-finalizer-guardian-work-in-java for a full explanation of how this works. This one should stay.
|
@fcalderonnearsoft Sorry for the delay - was out on vacation for a few days. I left a note on the finalizer guardian, but the others look fine to remove. If you can re-add the finalizer guardian, I will merge the PR. Thanks for the contribution! |
|
@mattrjacobs No problem, I already re-add finalizerguardian in a new commit. Cheers. |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #421 SUCCESS |
Removed methods and variables with unused annotation
I found more unused methods and variables related with #1150