New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected ignoreExceptions for Observable returning methods. #1273

Merged

mattrjacobs merged 1 commit into Netflix:master from jbojar:bugfix/ignore-exceptions-generic-observable-command

Jul 13, 2016

jbojar commented Jul 8, 2016 •

edited

Loading

Corrected not working ignoreExceptions for Observables. Issue #1272

changed GenericObservableCommand to correctly wrap ignorable exceptions in HystrixBadRequestException using Observable.onErrorResumeNext,
changed HystrixCommandAspect to uwrap HystrixBadRequestException and HystrixRuntimeException conveyed by observble the same way as normally thrown exceptions are uwrapped,
added test for ignoring errors in observables similar to BasicErrorPropagationTest.


          Corrected ignoreExceptions for Observable returning methods.

9a5d345

- error handling for observables
- tests

Contributor

mattrjacobs commented Jul 13, 2016

Thanks for the contribution, @jbojar !

mattrjacobs merged commit e336976 into Netflix:master

smjdowling mentioned this pull request

Hystrix Javanica not wrapping any exceptions #1285

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment