Javanica iss 907 #945
Javanica iss 907 #945
Conversation
|
NetflixOSS » Hystrix » Hystrix-pull-requests #212 FAILURE |
| } | ||
| } | ||
|
|
||
| task ajcTest(type: Test) { |
There was a problem hiding this comment.
@mattrjacobs I added this task that creates jar with aspects compiled using ajc, so now build task results to two jars:
hystrix-javanica.jar
hystrix-javanica-ctw.jar
Should we change something else to publish both artifacts correctly ?
|
NetflixOSS » Hystrix » Hystrix-pull-requests #213 FAILURE |
|
Looks like there's a merge conflict on hystrix-javanica/build.gradle, according to: https://netflixoss.ci.cloudbees.com/job/NetflixOSS/job/Hystrix/job/Hystrix-pull-requests/212/console Can you try to resolve that, so I can build locally and see what the gradle tasks do? |
|
@mattrjacobs yes, fill resolve. |
…nica-iss-907 Conflicts: hystrix-contrib/hystrix-javanica/build.gradle
|
NetflixOSS » Hystrix » Hystrix-pull-requests #218 SUCCESS |
|
@mattrjacobs I've got successful build https://netflixoss.ci.cloudbees.com/job/NetflixOSS/job/Hystrix/job/Hystrix-pull-requests/218/ |
|
Great, I'm checking it out now @dmgcodevil . Thanks for taking a look at all of the Javanica issues |
|
@dmgcodevil When I run the hystrix-javanica-1.5.0-SNAPSHOT.jar The ctw jar should have a version number, so that artifacts can get distinguished. Can you add that? |
|
@mattrjacobs Which plugin do you use to release artifact? How I can get version within gradle script ? |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #221 SUCCESS |
|
@mattrjacobs fixed, could you try again ? |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #222 SUCCESS |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #223 SUCCESS |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #224 SUCCESS |
|
@dmgcodevil This PR fixes the naming of the |
|
@mattrjacobs I've redesigned tests to check both compile and runtime weaving, also created simple app to check CTW and it works, I didn't find any issues. So go ahead to merge this PL |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #231 SUCCESS |
|
Thanks @dmgcodevil ! |
PL for hystrix javanica aspectj compile time weaving #907