Enable Hystrix Dashboard to monitor multiple independent applications #959
Conversation
Create a list of hystrix streams to monitor and monitor them independently using a monitor page. Backward compatible with existing monitor web url bookmarks. Implements Netflix#906.
|
NetflixOSS » Hystrix » Hystrix-pull-requests #235 SUCCESS |
|
I am not sure about why the test cases have failed. Travis build at the fork has succeeded with this commit. |
|
Thanks for the PR, @sasrin . I agree that the failing tests are unrelated. I'll take a look at seeing why CI is unhappy with them. I'll also play with the dashboard in your PR and give feedback there. If any other dashboard users want to give feedback, that would be very helpful as well |
|
@mattrjacobs ... sounds good. thank you. |
|
@sasrin My apologies for the delay on reviewing this. It looks like it works as expected to me. I can definitely imagine this would be very beneficial to many users - thanks for the contribution! I pointed at 2 instances that have a large number of commands (~200) and the dashboard performance was fairly slow. So I don't think this can be used in all cases, but I'm sure it will help certain applications. There's no reason it can't be used as before (single stream), so my strong inclination is to merge this. Does anybody object to merging this? |
Enable Hystrix Dashboard to monitor multiple independent applications
|
@mattrjacobs Thank you for accepting this pull request.
Agree with you about the slowness in refreshing the metrics and I did see similar behavior when I monitored six of our applications(approx. total of 35 endpoints to monitor) with a delay of few milliseconds rather than the default delay of 2 seconds. |
Streams, which breakerbox doesn't use, but the concept is nice.
Create a list of hystrix streams to monitor and monitor them independently
using a monitor page.
Backward compatible with existing monitor web url bookmarks.
Implements #906.