Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rx.util.Range.createWithCount(int start, int count) yields invalid sequence when start != 1 #164

Closed
christianbourgeois opened this issue Mar 1, 2013 · 4 comments

Comments

@christianbourgeois
Copy link

createWithCount(1, 4) correctly yields (1, 2, 3, 4)
createWithCount(2, 4) yields (2, 3, 4, 5, 6, 7, 8, 9) where it should be (2, 3, 4, 5)
createWithCount(0, 4) yields () where it should be (0, 1, 2, 3)
createWithCount(-1, 4) yields () where it should be (-1, 0, 1, 2)

@benjchristensen
Copy link
Member

Thanks @mairbek for the quick fix.

@christianbourgeois I have merged the fix (#165) and will include in the next release. I just want to review one more pull request to try and get it into that release.

It is okay if I wait until end of day today to release the new code or do you need the fix sooner?

@christianbourgeois
Copy link
Author

Thanks @mairbek for the quick fix and @benjchristensen for the merge.

You are all very fast, I was in the process of sending a pull request when I saw the fix by @mairbek.

This issue is not critical in any way for me, no worries for the release.

@benjchristensen
Copy link
Member

Then I'll finish up the other work before doing this release (hoping either end-of-day or over weekend).

Thanks for reporting the bug and being willing to submit a pull request (until @mairbek beat you to it!).

@mairbek
Copy link
Contributor

mairbek commented Mar 1, 2013

Thank you @christianbourgeois for reporting the issue.

I had shortly realized what a dumb mistake I made in that code :)

jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
…state.

* Added two gauges to monitor the circuit breaker state. One checks the
overall "open" state, the other one just reflects the state overall
(numerically).

The idea is to provide the ability to monitor on either of the two
metrics.

* Report the state of the CB as an individual metric

* Collapsing the state metrics to a single metric with an integer that
represents each state. The value is tied to the state enumeration.

* adding a fixed final int to the state so regardless of enum order the
integer representation states consistent. Made minor additions to the
dropwizard metrics doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants