Fixed synchronous ConnectableObservable.connect problem #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1089 SUCCESS |
| connect(new Action1<Subscription>() { | ||
| @Override | ||
| public void call(Subscription t1) { | ||
| out[0] = t1; |
There was a problem hiding this comment.
Clever.
Quite timely for you to have fixed this as I came across this problem just last night.
benjchristensen
added a commit
that referenced
this pull request
May 16, 2014
…usFix Fixed synchronous ConnectableObservable.connect problem
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectableObservable.connect returns a Subscription and thus cannot be unsubscribed synchronously, similar how take didn't work before the Subscriber changes. This PR modifies the
ConnectableObservableand its current implementationOperatorMulticastto extract the connection Subscription token before it is connected to the source. Cancelling this extracted token makes sure the synchronous connection is unsubscribed.(The Rx.NET version of the test case seemingly doesn't exhibit the problem. I suspect it is the interplay of
IDisposables.)