Add more operators to RxScala #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: language-adaptors/rxjava-scala/src/examples/scala/rx/lang/scala/examples/RxScalaDemo.scala
|
RxJava-pull-requests #1122 SUCCESS |
| observer.onNext(calculateElement(0)) | ||
| observer.onNext(calculateElement(1)) | ||
| observer.onCompleted() | ||
| Subscription {} | ||
| }) |
There was a problem hiding this comment.
Why do you want to change this? Users coming from C# will look for an Observable.create(Observer[T] => Subscription) example, and they should find something. Even if we completely remove Observable.create one day, I think we should leave this code (maybe commented out).
There was a problem hiding this comment.
Totally agreed; no harm in leaving this in. Also for folks that watch the coursera videos.
|
Nice examples in RxScalaDemo :) |
|
RxJava-pull-requests #1125 SUCCESS |
|
LGTM |
Conflicts: language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/CompletenessTest.scala
benjchristensen
added a commit
that referenced
this pull request
May 20, 2014
Add more operators to RxScala
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts against #1178, too. I will rebase once #1178 is merged to master.
/cc @samuelgruetter