Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplaySubject enhancement with time and/or size bounds #1223

Merged
merged 1 commit into from
May 20, 2014

Conversation

akarnokd
Copy link
Member

Reapplied the enhancements to bring size and/or time bound ReplaySubject capabilities while exposing a single subject class (i.e., no separate BoundedReplaySubject or CustomReplaySubject). It now uses the renewed SubjectSubscriptionManager.

In addition, I've moved a confusing behavior from SubjectObserver into AsyncSubject where it belongs.

@cloudbees-pull-request-builder

RxJava-pull-requests #1130 SUCCESS
This pull request looks good

import rx.schedulers.TestScheduler;
import rx.subjects.PublishSubject;

public class OperatorReplayTest {
@Test
public void testBoundedList() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these unit tests being deleted? Are they invalid behavior?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW ... I tried seeing if they had been moved, but I don't see the names of these tests elsewhere, so perhaps they were renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were testing the internal virtual list implementation in the CustomReplaySubject. Now that it is gone, there is no need for the test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. Thanks.

@benjchristensen
Copy link
Member

Thank you for this refactor ... it looks like it was tedious!

Just a simple question above and then will merge.

benjchristensen added a commit that referenced this pull request May 20, 2014
ReplaySubject enhancement with time and/or size bounds
@benjchristensen benjchristensen merged commit eab66ba into ReactiveX:master May 20, 2014
@akarnokd akarnokd deleted the BoundedReplaySubject520 branch May 20, 2014 16:31
@benjchristensen benjchristensen mentioned this pull request Jun 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants