Re-submission of CachedThreadScheduler #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1174 SUCCESS |
| import java.util.concurrent.*; | ||
| import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; | ||
|
|
||
| /* package */class CachedThreadScheduler extends Scheduler { |
There was a problem hiding this comment.
Sure, wasn't sure how it should be, since there doesn't seem to be any standard to follow there. ImmediateScheduler is final, but not EventLoopsScheduler or NewThreadScheduler.
|
Those should be final as well. I sometimes add them in one PR, forget to add them in another and at the end, a third PR gets merged without it. I plan to do another cleanup round before 1.0 so hopefully |
|
RxJava-pull-requests #1175 SUCCESS |
jbripley
changed the title
|
Testing with this code: public static void main(String[] args) {
Observable.timer(0, 10, TimeUnit.MILLISECONDS).take(100).flatMap(i -> {
return Observable.just(i).subscribeOn(Schedulers.io()).map(t -> {
try {
Thread.sleep(10);
} catch (Exception e) {
e.printStackTrace();
}
return t + "-" + Thread.currentThread();
});
}).toBlocking().forEach(System.out::println );
}Without this pull request it creates 100 threads: With this pull request it uses only 2 threads: |
|
Thanks @jbripley for this! |
benjchristensen
added a commit
that referenced
this pull request
May 30, 2014
Re-submission of CachedThreadScheduler
|
Thanks for all the pointers @akarnokd. I've learned a lot about both thread safe Java and how the |
|
You are welcome. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged in the latest from the master branch and refactored some internals in CachedThreadScheduler to better match the latest
Schedulerchanges. Aimed at solving #1140