Check unsubscribe within observable from future #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Creating an Observable from an already-cancelled Future should emit nothing (equivalent to Observable.never()) (it currently emits onError(CancellationException) 2) Creating an Observable from a Future then unsubscribeing immediately before Future.get() unblocks should be an Observable.never(). This test already passes.
…ithout emitting anything
|
RxJava-pull-requests #1190 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
May 30, 2014
…servable-from-future Check unsubscribe within observable from future
mattrjacobs
deleted the
check-unsubscribe-within-observable-from-future
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Observable.from(Future f) emits onError(CancellationException) when f starts out in a cancelled state. This change makes Observable.from(f) emit nothing in this case, and also when an unsubscribe occurs during a Future.get() that results in an Exception.