Hooked RxJavaPlugins errorHandler up within all operators that swallow onErrors #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w onErrors. * Otherwise, the only onErrors visible to plugin are the ones which propagate all the way to SafeSubscriber.
|
RxJava-pull-requests #1206 SUCCESS |
| void error(Throwable e) { | ||
| RxJavaPlugins.getInstance().getErrorHandler().handleError(e); |
There was a problem hiding this comment.
This does eventually emit the CompositeException. Is this consciously wanting to handle each error individually instead of only via the composite?
…- CompositeException is already visible
|
@benjchristensen The goal of this pull request is to make the minimal set of calls to the plugin that ensures each onError is seen by the plugin handler at least once. In this case, I think it's fine to let the ErrorHandler see the CompositeException and handle all errors contained within. I just removed the plugin code from the mergeDelayError operator, to that effect. |
|
RxJava-pull-requests #1208 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Jun 2, 2014
…swallowing-operators Hooked RxJavaPlugins errorHandler up within all operators that swallow onErrors
Closed
mattrjacobs
deleted the
add-error-handler-to-error-swallowing-operators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the only onErrors visible to RxJavaPlugins.errorHandler plugin are the ones which propagate all the way to SafeSubscriber.