Hide ChainedSubscription/SubscriptionList from Public API #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
RxJava-pull-requests #1209 SUCCESS |
|
Like. |
|
I agree with this variant. |
|
Great, thanks for the review. |
benjchristensen
added a commit
that referenced
this pull request
Jun 3, 2014
Hide ChainedSubscription/SubscriptionList from Public API
|
RxJava-pull-requests #1210 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding this type to the public API, it hides it as an internal implementation detail and does not expose it via the
Subscriberconstructor.If we want to expose it later we can figure out a proper name and do so.
This also changes operator implementations to not inject a
SubscriptionListbut instead just create theSubscriberand use it directly.