TakeWhile observables do not properly complete #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #38 SUCCESS |
|
Thank you for submitting a unit test along with the report. |
|
RxJava-pull-requests #47 SUCCESS |
|
This is an interesting bug in how it relates to a subject unsubscribe event. Your fix looks good. While confirming my understanding of the operator I looked at Rx.Net and your change matches what they do => https://rx.codeplex.com/SourceControl/changeset/view/aa25748a430e#Rx/NET/Source/System.Reactive.Linq/Reactive/Linq/Observable/TakeWhile.cs Merging fix. |
benjchristensen
added a commit
that referenced
this pull request
Mar 26, 2013
TakeWhile observables do not properly complete
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
TakeWhile observables do not properly complete
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…X#216) * Issue ReactiveX#197: Option to auto transition to half open * Issue ReactiveX#197: Option to auto transition, tidy up * Issue ReactiveX#197: Option to auto transition, reduce number of cb instances * Issue ReactiveX#197 Open to auto transition to half open, PR changes * Issue ReactiveX#197 Open to auto transition to half open, PR changes 2 * Issue ReactiveX#197 tidy up config after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See failing test case for an example.
This slipped through the tests because Observable.toObservable uses
Subscription.EMPTY, which means the onCompleted call after all three items
are produced calls the onComplete on the takeWhile observable, which already requested to be unsubscribed. The
undesired behaviour is shown with Observables that use subscriptions
(such as Subject) or inifinite Observables (which is how I ran into
this bug).
Similar bugs might exist elsewhere for other operations, because most
tests use Observable.toObservable rather than an Observable that uses
subscriptions.
The fix follows Rx.Net