Error Handling Improvements - User Provided Observers/Functions #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion failures Related to ReactiveX#216 The new forEach unit test went into a deadlock prior to this fix.
|
RxJava-pull-requests #68 SUCCESS |
…ors package - based on discussion at ReactiveX#221 - don't wrap at AtomicObserver again - anything outside of rx.operators will be wrapped
|
RxJava-pull-requests #69 SUCCESS |
|
I've incorporated the change to restrict "internal" identification to rx.operators. Merging as this seems to be a good step forward ... further changes can always come in via another pull request. |
benjchristensen
added a commit
that referenced
this pull request
Apr 2, 2013
Error Handling Improvements - User Provided Observers/Functions
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…ors package - based on discussion at ReactiveX#221 - don't wrap at AtomicObserver again - anything outside of rx.operators will be wrapped
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…-handling Error Handling Improvements - User Provided Observers/Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling as per discussion in issue #216
This is by no means exhaustive in the search for places needing this protection but gets the most obvious ones entering via
subscribeandforEach.The intention is to protect against exceptions being thrown and ensure onNext/onError/onCompleted contract compliance.