GroupBy fixes as reported in Issue 282 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2013
|
RxJava-pull-requests #156 FAILURE |
|
Not quite sure yet what's causing the test to fail on CloudBees. |
|
RxJava-pull-requests #160 FAILURE |
|
That failing test has nothing to do with GroupBy and is not one I've seen issues with before. CloudBees is really harsh on thread-scheduling ... |
ReactiveX#282 Refactored to maintain a single subscription that propagates events to the correct child GroupedObservables.
- support unsubscribing from parent and/or child - The following is now possible: ``` groupBy().take(1).mapMany(group -> group.take(20)) ``` - the subscription on the parent will cause new groups to stop being sent, but it will keep sending events until all previously created groups are unsubscribed from
Need these until we finish work at ReactiveX#204
- I specifically want to be testing with real threads here and not virtual time or a synchronous sequence so am giving it a range of counts that are acceptable
benjchristensen
added a commit
that referenced
this pull request
Jun 5, 2013
GroupBy fixes as reported in Issue 282
|
RxJava-pull-requests #162 SUCCESS |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…y-fixes GroupBy fixes as reported in Issue 282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #282